--- lib/PXElator/httpd.pm	2009/07/31 18:16:14	88
+++ lib/PXElator/httpd.pm	2009/07/31 22:52:22	104
@@ -39,6 +39,8 @@
 use html;
 our $static_pids;
 
+use Time::HiRes qw/time/;
+
 sub static {
 	my ($client,$path) = @_;
 
@@ -46,6 +48,8 @@
 
 	return if ! -f $full;
 
+	my $start_t = time();
+
 	if ( my $pid = fork ) {
 		# parent
 		close($client);
@@ -61,24 +65,31 @@
 
 	my $size = -s $full || return;
 
+	$client->autoflush(1);
+
 	print $client "HTTP/1.0 200 OK\r\nContent-Type: $type\r\nContent-Length: $size\r\nConnection: close\r\n\r\n";
 
 	open(my $fh, $full);
-	print "static $path $type $size\n";
 
-	my $block = 8192;
+	my $block = 1400; # try not to fragment packages (pxelinux seems to have problems with it)
 	my $buff;
 	my $pos = 0;
 
+	print "static $path $type $size block: $block\n";
+
 	while( my $len = read $fh, $buff, $block ) {
 		print $client $buff;
 		$pos += $len;
-		printf "%s %d/%d %.2f%%\r", $path, $pos, $size, $pos * 100 / $size;
+		printf "%s %d/%d %.2f%% %.2f K/s\r"
+			, $path, $pos
+			, $size, $pos * 100 / $size
+			, ( $pos / 1024 ) / ( time() - $start_t )
+			;
 	}
 	close($fh);
 	close($client);
 
-	print "$path $pos == $size OK\n";
+	print "\n";
 
 	exit;
 }
@@ -94,7 +105,7 @@
 	my $daemon = shift;
 	my $pid = $pids->{$daemon};
 
-	warn "start_stop $daemon $pid pids: ",dump( $pids );
+	warn "start_stop $daemon $pid\n";
 
 	if ( $pid =~ m{^\d+$} ) {
 		my $pstree = `pstree -p $pid`;
@@ -107,7 +118,7 @@
 		if ( $pid = fork ) {
 			# parent
 			$pids->{$daemon} = $pid;
-			warn "forked $daemon $pid";
+			warn "forked $daemon $pid\n";
 			return qq|$daemon pid $pid started|;
 		} elsif ( defined $pid ) {
 			# child
@@ -130,7 +141,7 @@
 sub get_request {
 	my ( $client, $path, $param ) = @_;
 
-	warn "get_request $client $path ",dump( $param );
+	warn "get_request $path ", $param ? dump( $param ) : '', "\n";
 
 	if ( my $found = static( $client,$path ) ) {
 		warn "static $found" if $debug;
@@ -147,13 +158,13 @@
 			'debug',	qq|<a href=/our/debug/| . boolean::toggle($debug) . qq|>$debug</a>|,
 		);
 
-		my $debug_proc;
+		my $debug_proc = '';
 
 		warn 'pids: ', dump( $pids ) if $debug;
 		foreach my $name ( sort keys %$pids ) {
 			my $pid = $pids->{$name} || next;
 
-			my $html = qq|<a href=/$name>$pid</a>|;
+			my $html = qq|<a href=/start_stop/$name>$pid</a>|;
 
 			my $proc = "/proc/$pid/status";
 
@@ -180,18 +191,24 @@
 			push @rows, ( $name => $html );
 		}
 
+		my $below_table = '';
+
 		warn 'static_pids: ', dump( $static_pids ) if $debug;
 		foreach my $pid ( keys %$static_pids ) {
 			my $path = $static_pids->{$pid};
 			if ( -d "/proc/$pid" ) {
 				push @rows, ( $path => qq|<a href=/kill/static/$pid>$pid</a>| );
+			} elsif ( $param->{clean_completed_downloads} ) {
+				delete $static_pids->{$pid}
 			} else {
 				push @rows, ( $path => "$pid competed" );
+				$below_table = qq|<a href="/?clean_completed_downloads=1">clean completed downloads</a>|;
 			}
 		}
 
 		print $client $ok
 			, html::table( 2, @rows )
+			, $below_table
 			, html::tabs( log::mac_changes )
 			, $debug_proc
 			;
@@ -201,7 +218,7 @@
 		warn $@ if $@;
 		print $client $redirect, qq|<big>$1 = $2</big><br>Location: <a href="$url">$url</a>|;
 		server::debug( $debug ) if $1 eq 'debug';
-	} elsif ( $path =~ m{^/start_stop/((?:screen|kvm).*)} ) {
+	} elsif ( $path =~ m{^/start_stop/((?:screen|kvm).*)} ) { # XXX we don't want to stop all classes
 		print $client $redirect, start_stop($1);
 	} elsif ( $path =~ m{^/action/([^/]+)/(.+)} ) {
 		$1->$2();
@@ -262,7 +279,6 @@
 				}
 				warn "param: ",dump( $param ) if $debug;
 			}
-			warn "path $path param: ",dump( $param );
 			get_request $client, $path, $param;
 		} else {
 			print $client "HTTP/1.0 500 No method\r\nConnection: close\r\nContent-type: text/plain\r\n\r\n500 $request";