--- trunk/lib/Frey/Web.pm 2008/11/26 04:26:43 529
+++ trunk/lib/Frey/Web.pm 2008/11/26 16:17:17 535
@@ -50,19 +50,34 @@
documentation => 'Maximum dump size sent to browser before truncation',
);
-=head2 inline_smaller_than
-
-Inline JavaScript and CSS smaller than this size into page reducing
-round-trips to server.
-
-=cut
-
has 'inline_smaller_than' => (
is => 'rw',
isa => 'Int',
default => 10240,
+ documentation => 'Inline JavaScript and CSS to reduce round-trips',
+);
+
+has 'chop_warning' => (
+ is => 'rw',
+ isa => 'Int',
+ default => 80,
+ documentation => 'Crop lines longer',
);
+my %escape = ('<'=>'<', '>'=>'>', '&'=>'&', '"'=>'"');
+my $escape_re = join '|' => keys %escape;
+
+sub html_escape {
+ my ( $self, $html ) = @_;
+ $html =~ s/($escape_re)/$escape{$1}/g;
+ return $html;
+}
+
+sub html_dump {
+ my $self = shift;
+ $self->html_escape( dump( @_ ) );
+}
+
sub dom2html {
# warn "## dom2html ",dump( @_ );
return Continuity::Widget::DomNode->create( @_ )->to_string;
@@ -185,26 +200,7 @@
$body = '';
}
- my $warn_colors = {
- '#' => '#444',
- '##' => '#888',
- };
-
- $status_line
- .= qq||
- if $self->warnings;
+ $status_line .= $self->warnings_html;
my ($exit,$description) = ('exit','stop server');
($exit,$description) = ('restart','restart server')
@@ -370,4 +366,79 @@
}
+my $warn_colors = {
+ '#' => '#444',
+ '##' => '#888',
+};
+
+my $multiline_markers = {
+ '(' => ')',
+ '{' => '}',
+ '[' => ']',
+ '"' => '"',
+};
+
+my $multiline_re = '[\\' . join('\\', keys %$multiline_markers ) . ']';
+warn "## multiline markers ", dump( $multiline_markers ), " -> $multiline_re";
+
+sub log_path {
+ $Frey::Bootstrap::log_path || warn "no log_path?";
+}
+
+sub warnings_html {
+ my ($self,$level) = shift;
+ $level ||= $self->debug,
+ my $path = $self->log_path;
+
+ my $warnings;
+ my $line = 0;
+ my $multiline_end;
+
+ open(my $log, '<', $path) || die "can't open $path: $!";
+ while(<$log>) {
+ chomp;
+ $line++;
+
+ my $style = '';
+
+ if ( $multiline_end ) {
+ if ( m{^\Q$multiline_end\E} || m{^\s.+\Q$multiline_end\E;$} ) {
+ warn "## $line end of $multiline_end in '$_'\n";
+ undef $multiline_end;
+ } else {
+ warn "## $line skipped\n";
+ }
+ } elsif ( m{^(#*)\s+} ) {
+ my $l = $1 ? length($1) : 0;
+ if ( $l > $level ) {
+ undef $multiline_end;
+ $multiline_end = $multiline_markers->{$1} if m{($multiline_re)$};
+ warn "## $line start $1 .. $multiline_end level $l > $level for '$_'\n" if $multiline_end;
+ next;
+ }
+
+ $style = $warn_colors->{$1}
+ ? ' style="color:' . $warn_colors->{$1} . '"'
+ : '';
+
+ my $msg = $self->html_escape( $_ );
+ my $spacer = ' ';
+ if ( length($msg) > $self->chop_warning ) {
+ $msg = substr( $msg, 0, $self->chop_warning );
+ $spacer = '…'
+ }
+ $msg =~ s{^\s}{ }g;
+ $warnings .= qq|$msg$spacer+$line
|;
+ # FIXME should be but CSS hates me
+ }
+ }
+ close($log) || die "can't close $path: $!";
+
+ return
+ qq||
+ ;
+}
+
1;