--- trunk/lib/Frey/SVK.pm	2008/11/28 19:23:38	603
+++ trunk/lib/Frey/SVK.pm	2008/11/29 16:17:18	620
@@ -4,13 +4,22 @@
 extends 'Frey';
 with 'Frey::Web';
 
-has commit_path => (
-	documentation => 'path to commit',
+use Moose::Util::TypeConstraints;
+
+enum 'SVK_Action' => ( 'commit', 'revert' );
+
+has action => (
 	is => 'rw',
-	isa => 'ArrayRef|Str',
+	isa => 'SVK_Action',
 );
 
-has message => (
+has path => (
+	documentation => 'path to work with',
+	is => 'rw',
+	isa => 'Str',
+);
+
+has commit_message => (
 	documentation => 'commit message',
 	is => 'rw',
 	isa => 'Str',
@@ -57,19 +66,32 @@
 sub status_as_markup {
 	my ($self) = @_;
 	my $status = `svk status -q`;
-	$status =~ s{^(\w+\s+)(\S+)$}{$1<input name="commit_path" value="$2" type="checkbox"><a href="#$2">$2</a>}gm;
+#	$status =~ s{^(\w+\s+)(\S+)$}{$1<input name="commit_path" value="$2" type="checkbox"><a href="#$2">$2</a>}gm; # FIXME
+	$status =~ s{^(\w+\s+)(\S+)$}{$1<a href="#$2">$2</a>}gm;
 	if ( $status ) {
-		$self->add_css( qq| pre.l a { text-decoration: none; } | );
+		$self->add_css(qq|
+			pre.l a { text-decoration: none; }
+			div.commit {
+				background: #ffd;
+				padding: 1em 1em;
+				position: fixed;
+				top: 1em;
+				right: 1em;
+				z-index: 10;
+			}
+		| );
+
 		$status = qq|
-			<form>
-			<div style="background: #ffd; float: right; padding: 1em;">
-				<textarea name="message" width=20 height=4></textarea>
-				<br><input type="submit" value="Commit">
+			<div class="commit">
+				<form>
+				<textarea name="commit_message" cols=40 rows=4></textarea>
+				<br><input type="submit" name="action" value="commit">
+				</form>
 			</div>
 			<pre class="l">$status</pre>
-			</form>
 		|;
 		$self->add_status( $status );
+
 	}
 	warn "status_as_markup ",length($status)," bytes";
 	return $status;
@@ -84,10 +106,11 @@
 	$self->add_css( qq|
 	pre span.add { background: #dfd }
 	pre span.del { background: #fdd }
+	pre form.revert { display: inline }
 	| );
 	$diff =~ s{^(\+.+?)$}{<span class="add">$1</span>}gm;
 	$diff =~ s{^(\-.+?)$}{<span class="del">$1</span>}gm;
-	$diff =~ s{^(===\s+)(\S+)$}{$1<a name="$2">$2</a>}gm;
+	$diff =~ s{^(===\s+)(\S+)$}{$1<form class="revert"><input type="hidden" name="path" value="$2"><input type="submit" name="action" value="revert"></form> <a name="$2" target="editor" href="/editor+$2+1">$2</a>}gm;
 
 	$diff = qq|<pre>$diff</pre>|;
 	warn "diff_as_markup ",length($diff)," bytes";
@@ -97,15 +120,39 @@
 sub as_markup {
 	my ($self) = @_;
 
+	my $html = '';
+
+	if ( $self->action ) {
+		my $cmd = 'svk ' . $self->action . ' ' . $self->path;
+		if ( $self->action eq 'commit' ) {
+			confess "need commit message" unless $self->commit_message;
+			my $msg = $self->commit_message;
+			$msg =~ s{"}{\\"}gs;
+			$cmd .= qq{ -m "$msg"};
+		} else {
+			confess "need path" unless $self->path;
+		}
+		$cmd .= ' 2>&1';
+		my $out = `$cmd`;
+		warn "$cmd $out";
+		$html .= qq|
+			<code style="background: #ff8;">
+			$cmd\n
+			<b>$out</b>
+			</code>
+		|;
+	}
+
+	$self->title( 'svk' . ( $self->action ? ' - ' . $self->action : '' ) ); # XXX without this we get wrong icon and title
+
 	if ( ! $self->can('html_escape') ) {
 		Frey::Web->meta->apply( $self );
 		$self->TODO( "Frey::Web role missing" );
 	}
 
-	my $html
-		= ( $self->status_as_markup || $self->error('no status_or_markup output') )
-		. ( $self->diff_as_markup   || $self->error('no diff_as_markup output') )
-		;
+	$html .= $self->status_as_markup || 'No changes in files tracked by SVK';
+	$html .= $self->diff_as_markup;
+
 	warn "as_markup ",length($html)," bytes";
 
 	return $html;