--- trunk/lib/Frey/SVK.pm	2008/11/29 00:20:23	614
+++ trunk/lib/Frey/SVK.pm	2008/11/29 01:01:14	615
@@ -4,16 +4,19 @@
 extends 'Frey';
 with 'Frey::Web';
 
-has commit_path => (
-	documentation => 'path to commit',
+use Moose::Util::TypeConstraints;
+
+enum 'SVK_Action' => ( 'commit', 'revert' );
+
+has action => (
 	is => 'rw',
-	isa => 'ArrayRef|Str',
+	isa => 'SVK_Action',
 );
 
-has revert_path => (
-	documentation => 'path to commit',
+has path => (
+	documentation => 'path to work with',
 	is => 'rw',
-	isa => 'ArrayRef|Str',
+	isa => 'Str',
 );
 
 has message => (
@@ -63,19 +66,32 @@
 sub status_as_markup {
 	my ($self) = @_;
 	my $status = `svk status -q`;
-	$status =~ s{^(\w+\s+)(\S+)$}{$1<input name="commit_path" value="$2" type="checkbox"><a href="#$2">$2</a>}gm;
+#	$status =~ s{^(\w+\s+)(\S+)$}{$1<input name="commit_path" value="$2" type="checkbox"><a href="#$2">$2</a>}gm; # FIXME
+	$status =~ s{^(\w+\s+)(\S+)$}{$1<a href="#$2">$2</a>}gm;
 	if ( $status ) {
-		$self->add_css( qq| pre.l a { text-decoration: none; } | );
+		$self->add_css(qq|
+			pre.l a { text-decoration: none; }
+			div.commit {
+				background: #ffd;
+				padding: 1em 1em;
+				position: fixed;
+				top: 1em;
+				right: 1em;
+				z-index: 10;
+			}
+		| );
+
 		$status = qq|
-			<form>
-			<div style="background: #ffd; float: right; padding: 1em;">
-				<textarea name="message" width=20 height=4></textarea>
-				<br><input type="submit" value="Commit">
+			<div class="commit">
+				<form>
+				<textarea name="message" cols=40 rows=4></textarea>
+				<br><input type="submit" name="action" value="commit">
+				</form>
 			</div>
 			<pre class="l">$status</pre>
-			</form>
 		|;
 		$self->add_status( $status );
+
 	}
 	warn "status_as_markup ",length($status)," bytes";
 	return $status;
@@ -94,7 +110,7 @@
 	| );
 	$diff =~ s{^(\+.+?)$}{<span class="add">$1</span>}gm;
 	$diff =~ s{^(\-.+?)$}{<span class="del">$1</span>}gm;
-	$diff =~ s{^(===\s+)(\S+)$}{$1<form class="revert"><input type="hidden" name="revert_path" value="$2"><input type="submit" value="Revert"></form> <a name="$2">$2</a>}gm;
+	$diff =~ s{^(===\s+)(\S+)$}{$1<form class="revert"><input type="hidden" name="path" value="$2"><input type="submit" name="action" value="revert"></form> <a name="$2">$2</a>}gm;
 
 	$diff = qq|<pre>$diff</pre>|;
 	warn "diff_as_markup ",length($diff)," bytes";
@@ -106,14 +122,28 @@
 
 	my $html = '';
 
-	if ( $self->revert_path ) {
-		my $cmd = 'svk revert ' . join(' ', $self->revert_path );
-		my $revert = `$cmd`;
-		warn "$cmd $revert";
-		$html .= qq|<code style="background: #ff8;">$revert</code>|;
+	if ( $self->action ) {
+		my $cmd = 'svk ' . $self->action . ' ' . $self->path;
+		if ( $self->action eq 'commit' ) {
+			confess "need message" unless $self->message;
+			my $msg = $self->message;
+			$msg =~ s{"}{\\"}gs;
+			$cmd .= qq{ -m "$msg"};
+		} else {
+			confess "need path" unless $self->path;
+		}
+		$cmd .= ' 2>&1';
+		my $out = `$cmd`;
+		warn "$cmd $out";
+		$html .= qq|
+			<code style="background: #ff8;">
+			$cmd\n
+			<b>$out</b>
+			</code>
+		|;
 	}
 
-	$self->title('svk'); # XXX without this we get wrong icon and title
+	$self->title( 'svk' . ( $self->action ? ' - ' . $self->action : '' ) ); # XXX without this we get wrong icon and title
 
 	if ( ! $self->can('html_escape') ) {
 		Frey::Web->meta->apply( $self );