--- trunk/lib/Frey/Run.pm 2008/11/19 02:14:48 443 +++ trunk/lib/Frey/Run.pm 2008/11/19 16:53:13 457 @@ -28,8 +28,9 @@ use Moose::Util::TypeConstraints; -sub runnable { qw/data data.js markup sponge/ } -enum 'Runnable' => runnable; +subtype 'Runnable' + => as 'Str', + => where sub { m{^as_} }; sub formats_available { qw/html js json yaml yml/ } enum 'Formats' => formats_available; @@ -49,7 +50,7 @@ has 'run' => ( is => 'rw', isa => 'Runnable', - default => 'markup', + default => 'as_markup', ); has 'format' => ( @@ -77,37 +78,35 @@ if ( $is_role ) { $o = $instance; } else { - $o = $class->new( %{ $self->params } ); + $o = $self->new_frey_class( $class, $self->params ); } $o->depends if $o->can('depends'); push @{ $self->status }, { qq|$class| => $self->params }; - if ( $self->run eq 'markup' ) { - warn "## using ",ref($o), "->markup"; + if ( $self->run eq 'as_markup' ) { + warn "## using ",ref($o), "->as_markup"; if ( $o->can('page') ) { - #$html = $o->page; - $body = $o->markup unless $html; - } else { - $body = $o->markup; + $html = $o->page; } + $body = $o->as_markup unless $html; warn ">>> markup $class ",length( $html || $body ), " ", $html ? 'html' : 'body', " bytes"; - } elsif ( $self->run eq 'sponge' ) { - $data = $o->sponge; + } elsif ( $self->run eq 'as_sponge' ) { + $data = $o->as_sponge; confess "invalid data from sponge = ", dump( $data ) unless ref($data) eq 'HASH'; if ( $self->format eq 'html' ) { my $rows = $#{ $data->{rows} } + 1; $rows ||= 'no'; - $body .= "$rows rows from $class->new" . dump( $self->params ) . "->sponge"; + $body .= "$rows rows from $class->new" . dump( $self->params ) . "->as_sponge"; $body .= ''; $body .= ''; $body .= '' foreach @{ $data->{rows} }; $body .= '
' . join('', @{$data->{NAME}} ) . '
' . join('', @$_ ) . '
'; } - } elsif ( $self->run eq 'data' ) { - $data = $o->data; + } elsif ( $self->run eq 'as_data' ) { + $data = $o->as_data; } else { $body = $self->error( "IGNORE: $class ", $o->dump ); } @@ -118,7 +117,7 @@ push @{ $self->status }, { 'data' => $data }; } if ( ! $html ) { - $body .= Frey::Dumper->new( data => $data )->markup; + $body .= Frey::Dumper->new( data => $data )->as_markup; } # override our status with one from object