--- trunk/lib/Frey/Action.pm	2008/11/17 22:40:22	386
+++ trunk/lib/Frey/Action.pm	2008/11/19 00:39:23	430
@@ -37,12 +37,19 @@
 	my ( $self ) = @_;
 	$self->load_class( $self->class );
 	my @required = 
-		grep {
-			defined $_ && $_->can('name') && !defined( $self->params->{ $_->name } )
-		}
+		grep { defined $_ }
 		map {
-			my $attr = $self->class->meta->get_attribute($_);
-			$attr->is_required && $attr;
+			eval {
+				$_->can('name') && !defined( $self->params->{ $_->name } )
+			};
+		}
+		grep {
+			my $required = eval {
+				my $attr = $self->class->meta->get_attribute($_);
+				$attr->is_required;
+			};
+			warn "# attribute $_ error: $@" if $@;
+			$required;
 		} $self->class->meta->get_attribute_list;
 
 	warn "## required = ",dump( map { $_->name } @required ), " for ", $self->class if @required && $self->debug;
@@ -82,11 +89,11 @@
 	my ( $self ) = @_;
 	my @required = $self->required;
 	if ( ! @required ) {
-		warn "all params available ", dump( $self->params ), " not creating form";
+		warn "all params available ", dump( $self->params ), " not creating form" if $self->debug;
 		return (undef,$self->params) if wantarray;
 		return;
 	} else {
-		warn $self->class, " required params ", dump( @required ) if $self->debug;
+		warn $self->class, " required params ", map { $_->dump(2) } @required if $self->debug;
 	}
 
 	my $class = $self->class;
@@ -102,7 +109,7 @@
 	my $form;
 
 	foreach my $name ( grep { ! $class->meta->get_attribute($_)->is_lazy } $self->attributes ) {
-		my $attr_type;
+		my $attr_type = '';
 		my $type = $name =~ m/^pass/ ? 'password' : 'text';
 		my $label = $name;
 		my $value = '';
@@ -119,8 +126,8 @@
 			) . qq|</select>|;
 			$default->{$name} = $config_params->[0]->{$name};
 		} elsif ( my $attr = $class->meta->get_attribute( $name ) ) {
-			$attr_type = $attr->type_constraint->name;
 			if ( $attr->has_type_constraint ) {
+				$attr_type = $attr->type_constraint->name;
 				if ( $attr->type_constraint->can('values') ) {
 					$value_html = qq|<select name="$name">| . join("\n",
 						map { qq|<option value="$_">$_</option>| } @{ $attr->type_constraint->values }
@@ -142,11 +149,13 @@
 #		warn "# required $name ", $class->meta->get_attribute( $name )->dump( 2 );
 		$form .= qq|<label for="$name"$label_title>$label</label>| . $value_html;
 	}
-	my $html = join("\n",
-		qq|<h1>$class params</h1><form method="post">$form<input type="submit" value="Run $class"></form>|,
-		qq|<span class="frey-popdown">config<span><code>|  . dump( $config_params ) . qq|</span></span>|,
-		qq|<span class="frey-popdown">default<span><code>| . dump( $default )       . qq|</span></span>|,
-	) if $form;
+	my $html = qq|<h1>$class params</h1><form method="post">$form<input type="submit" value="Run $class"></form>|;
+	push @{ $self->status }, { 'Params' =>
+		{
+			'Config'  => $config_params,
+			'Default' => $default
+		},
+	};
 
 	return ($html,$default) if wantarray;
 	return $html;