--- trunk/lib/Frey/Web.pm 2008/11/30 14:02:35 634 +++ trunk/lib/Frey/Web.pm 2008/12/11 21:36:04 816 @@ -3,21 +3,22 @@ with 'Frey::Session'; -use Frey::Types; - #use Continuity::Widget::DomNode; use Data::Dump qw/dump/; -use Carp qw/confess cluck/; +use Carp qw/confess cluck carp/; use File::Slurp; +use Text::Tabs; # expand, unexpand + +use lib 'lib'; + +use Frey::Types; use Frey::Bookmarklet; -use Frey::ClassBrowser; +use Frey::Class::Browser; use Frey::INC; use Frey::SVK; -use Text::Tabs; # expand, unexpand - our @head; sub head { @head } @@ -26,7 +27,7 @@ isa => 'Uri', coerce => 1, required => 1, default => sub { - cluck "undefined request_url"; + carp "undefined request_url"; '/'; }, ); @@ -86,14 +87,14 @@ $dump =~ s{(\n[^\n]{$width})([^\n]+?)([^\n]{5})}{\n$1...$3}gs; $dump = $self->html_escape( $dump ); $dump =~ s{\Q...\E}{…}gs; -# $dump =~ $self->editor_links( $dump ); # FIXME include this +# $dump =~ $self->html_links( $dump ); # FIXME include this return "$dump"; } sub popup { my $self = shift; $self->popup_dropdown('popup', @_); } sub dropdown { my $self = shift; $self->popup_dropdown('dropdown', @_); } -our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1|[^>]+/)>}s; # relaxed html check for one semi-valid tag +our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1|[^>]+/?)>}s; # relaxed html check for one semi-valid tag sub popup_dropdown { my ( $self, $type, $name, $content, $full ) = @_; @@ -184,6 +185,26 @@ | ); } +sub add_js { + my ($self,$js) = @_; + my ( $package, $path, $line ) = caller; + + if ( $js =~ m{http.*\.js} ) { + $self->add_head( qq| + + |); + } else { + $self->add_head( qq| + + | ); + }; +} + our $reload_counter = 0; @@ -225,7 +246,10 @@ if ( ! $body ) { my $run = $a->{run} || 'as_markup'; warn "# no body, invoke $self->$run on ", ref($self); - $body = $self->$run; + eval { + $body = $self->$run; + }; + $body = $self->error( $@, '' ) if $@; } if ( $self->content_type !~ m{html} ) { warn "# return only $self body ", $self->content_type; @@ -245,7 +269,7 @@ qq| reload - $exit + $exit |; @@ -301,39 +325,70 @@ qq|>$class|; } -=head2 editor_links +=head2 html_links Create HTML links to editor for perl error message - my $html = $self->editor_links( $error ) + my $html = $self->html_links( $error ) =cut -sub editor_links { +sub html_links { my ( $self, $error ) = @_; + $error = $self->strip_full_path( $error ); + # $error =~ s[(bless\({\s+.+?\s+},\s+)("[^"]+")(\) at)][$1$2$3]gs; # FIXME insert bless hiding back + # perl's backtrace $error =~ s{at\s+(\S+)\s+line\s+(\d+)} - {at $1 line $2}gsm; + {at $1 line $2}gsm; + + $error =~ s{(via (?:package)\s+"?)([\w:]+)("?)} + {$1$2$3}gsm + || # or anything that looks like "Class::Name" + $error =~ s{"(\w+(?:::\w+)+)"} + {"$1"}gsm; + + # method error messages + # FIXME replace with link to Frey::Introspect data + $error =~ s{(method ")(\w+)(" via)} + {$1$2$3}gsm; + + # link paths to editor + $error =~ s{((?:lib|t)/[\S]+)\s+(\d+\s+bytes)} + {$1}gsm; - $error =~ s{(via (?:package) "?)([\w:]+)("?)} - {$1$2$3}gsm; + $error =~ s{(class ")([\w:]+)(")} + {$1$2$3}gsm; return $error; } +=head2 error + +This method will return error to browser and backtrace unless +error message ends with LF C<\n> just like L + +=cut + sub error { my $self = shift; my $error = join(" ", @_); - my @backtrace = $self->backtrace; - $error .= "\n\t" . join( "\n\t", @backtrace ) if @backtrace; + my $fatal = ''; + + if ( $error !~ m{\n$} ) { + if ( my @backtrace = $self->backtrace ) { + $error .= "\n\t" . join( "\n\t", @backtrace ); + $fatal = qq| frey-fatal|; + } + } warn "ERROR: $error\n"; return - qq|
|
-		. $self->editor_links( $error ) .
+		qq|
|
+		. $self->html_links( $error ) .
 		qq|
| ; } @@ -373,11 +428,10 @@ sub clean_status { my ($self) = shift; @head = ( 'static/frey.css' ); - my $params = { request_url => $self->request_url }; @status = ( - { 'ClassBrowser' => Frey::ClassBrowser->new( %$params, usage_on_top => 0 )->as_markup }, - { 'Bookmarklets' => Frey::Bookmarklet->new( %$params )->as_markup }, - { 'INC' => Frey::INC->new( %$params )->as_markup }, + { 'ClassBrowser' => Frey::Class::Browser->new( usage_sort => 1, usage_on_top => 0 )->as_markup }, + { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }, + { 'INC' => Frey::INC->new->as_markup }, ); $icon_html = ''; } @@ -412,15 +466,28 @@ sub icon_path { my ($self,$class,$variant) = @_; - my $icon = $class; - $icon =~ s{::}{/}g; - $icon .= "/$variant" if $variant; - my $path = 'static/icons/' . $icon . '.png'; +# $class ||= $self->title; + + sub icon_exists { + my $class = shift; + $class =~ s{::}{/}g; + $class .= "/$variant" if $variant; + my $icon_path = 'static/icons/' . $class . '.png'; + return $icon_path if -e $icon_path; + return; + } + + my $path = icon_exists( $class ); + + while ( $class =~ s{::[^:]+$}{} && ! $path ) { + $path = icon_exists( $class ) unless $class eq 'Frey'; # don't default on Frey icon + } + if ( -e $path ) { warn "# $class from $self icon_path $path" if $self->debug; return $path; } else { - $self->TODO( "add $path icon for $class" ); + $self->TODO( "add $path icon for $class $variant" ); return undef; } } @@ -462,13 +529,31 @@ '"' => '"', }; +=for later + my $multiline_re = '[\\' . join('\\', keys %$multiline_markers ) . ']'; warn "## multiline markers ", dump( $multiline_markers ), " -> $multiline_re"; +=cut + sub log_path { $Frey::Bootstrap::log_path || die "no log_path?"; } +our $pwd = `pwd`; +chomp $pwd; + +sub strip_full_path { + my ($self, $msg) = @_; + # Mojo seems to expand warn messages to full path which is annoying + $msg =~ s{/[^/]+/\.\./}{/}gs; + $msg =~ s{$pwd/*}{}gs; + return $msg; +} + +our $last_log_pos = 0; +our $last_log_line = 0; + sub warnings_html { my ($self,$level) = shift; $level ||= $self->debug, @@ -477,7 +562,7 @@ my $max = 30; my $pos = 0; my @warnings = ( '' x $max ); # XXX circualar buffer for 50 lines - my $line = 0; + my $line = $last_log_line; my $multiline_end; # XXX do we really want to do this every time? @@ -491,7 +576,8 @@ } $self->add_css( $css ); - open(my $log, '<', $path) || die "can't open $path: $!"; + open(my $log, '<', $path) || die "can't open $path: $!"; + seek($log, $last_log_pos, 0) || warn "can't seek: $!"; while(<$log>) { chomp; $line++; @@ -522,7 +608,7 @@ if ( m{^(#*)} ) { my $level = $1; - my $msg = $_; + my $msg = $self->strip_full_path( $_ ); my $spacer = ' '; my $real_msg = expand( $msg ); @@ -547,7 +633,9 @@ $warnings[ $pos++ % $max ] = $msg; } } - warn "log has $line lines tell position ",tell($log); + $last_log_pos = tell($log); + $last_log_line = $line; + warn "log has $line lines tell position $last_log_pos"; close($log) || die "can't close $path: $!"; my $size = -s $path; @@ -561,8 +649,8 @@ return # need to wrap editor link into span so we can have links in warnings qq|warn| - . $self->editor_links( $warnings ) - . qq|| + . $self->html_links( $warnings ) + . qq|| ; } @@ -588,10 +676,45 @@ ) = caller($_) or last; push @backtrace, - qq|via $package at $path line $line|; + qq|via "$package" at $path line $line|; } #warn "# backtrace: ", dump( @backtrace ) if @backtrace; return @backtrace; } +=head2 checkbox + +Generate checkbox html markup from some attribute + + my $html = $self->checkbox('attribute_name', $value); + +=cut + +sub checkbox { + my ($self,$name,$value) = @_; + my $checked = ''; + my $all_checkboxes = eval { $self->$name }; + warn "ERROR tried to get checkbox value for '$name' which is unknown: $@" if $@; + $all_checkboxes = [ $all_checkboxes ] unless ref($all_checkboxes) eq 'ARRAY'; # sigh, too chatty + $checked = ' checked' if grep { defined $_ && $_ eq $value } @$all_checkboxes; + warn "# checkbox $name $value $checked\t", $self->dump( $self->$name ); + qq||; +} + +=head2 strip + +Strip whitespace around content + + my $stripped = strip(' no more whitespace around this '); + +=cut + +sub strip { + my $t = shift; + $t =~ s{^\s+}{}gs; + $t =~ s{>\s+<}{><}gs; + $t =~ s{\s+$}{}gs; + return $t; +} + 1;