--- trunk/lib/Frey/Web.pm 2008/12/02 02:05:55 678
+++ trunk/lib/Frey/Web.pm 2008/12/14 14:13:35 835
@@ -3,21 +3,22 @@
with 'Frey::Session';
-use Frey::Types;
-
#use Continuity::Widget::DomNode;
use Data::Dump qw/dump/;
use Carp qw/confess cluck carp/;
use File::Slurp;
+use Text::Tabs; # expand, unexpand
+
+use lib 'lib';
+
+use Frey::Types;
use Frey::Bookmarklet;
-use Frey::ClassBrowser;
+use Frey::Class::Browser;
use Frey::INC;
use Frey::SVK;
-use Text::Tabs; # expand, unexpand
-
our @head;
sub head { @head }
@@ -86,14 +87,14 @@
$dump =~ s{(\n[^\n]{$width})([^\n]+?)([^\n]{5})}{\n$1...$3}gs;
$dump = $self->html_escape( $dump );
$dump =~ s{\Q...\E}{…}gs;
-# $dump =~ $self->editor_links( $dump ); # FIXME include this
+# $dump =~ $self->html_links( $dump ); # FIXME include this
return "$dump";
}
sub popup { my $self = shift; $self->popup_dropdown('popup', @_); }
sub dropdown { my $self = shift; $self->popup_dropdown('dropdown', @_); }
-our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1|[^>]+/)>}s; # relaxed html check for one semi-valid tag
+our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1|[^>]+/?)>}s; # relaxed html check for one semi-valid tag
sub popup_dropdown {
my ( $self, $type, $name, $content, $full ) = @_;
@@ -184,6 +185,26 @@
| );
}
+sub add_js {
+ my ($self,$js) = @_;
+ my ( $package, $path, $line ) = caller;
+
+ if ( $js =~ m{http.*\.js} ) {
+ $self->add_head( qq|
+
+ |);
+ } else {
+ $self->add_head( qq|
+
+ | );
+ };
+}
+
our $reload_counter = 0;
@@ -225,10 +246,7 @@
if ( ! $body ) {
my $run = $a->{run} || 'as_markup';
warn "# no body, invoke $self->$run on ", ref($self);
- eval {
- $body = $self->$run;
- };
- $body = $self->error( $@, '' ) if $@;
+ $body = $self->$run;
}
if ( $self->content_type !~ m{html} ) {
warn "# return only $self body ", $self->content_type;
@@ -304,17 +322,19 @@
qq|>$class|;
}
-=head2 editor_links
+=head2 html_links
Create HTML links to editor for perl error message
- my $html = $self->editor_links( $error )
+ my $html = $self->html_links( $error )
=cut
-sub editor_links {
+sub html_links {
my ( $self, $error ) = @_;
+ $error = $self->strip_full_path( $error );
+
# $error =~ s[(bless\({\s+.+?\s+},\s+)("[^"]+")(\) at)][$1$2$3]gs; # FIXME insert bless hiding back
# perl's backtrace
@@ -333,8 +353,11 @@
{$1$2$3}gsm;
# link paths to editor
- $error =~ s{(lib/[\w/]+\.pm)(\s+(\d+)\s+bytes)}
- {$1}gsm;
+ $error =~ s{((?:lib|t)/[\S]+)\s+(\d+\s+bytes)}
+ {$1}gsm;
+
+ $error =~ s{(class ")([\w:]+)(")}
+ {$1$2$3}gsm;
return $error;
}
@@ -355,14 +378,15 @@
if ( $error !~ m{\n$} ) {
if ( my @backtrace = $self->backtrace ) {
$error .= "\n\t" . join( "\n\t", @backtrace );
- $fatal = qq| class="fatal"|;
+ $fatal = qq| frey-fatal|;
}
}
warn "ERROR: $error\n";
+ $self->add_icon('error');
return
qq||
- . $self->editor_links( $error ) .
+ . $self->html_links( $error ) .
qq|
|
;
}
@@ -403,7 +427,7 @@
my ($self) = shift;
@head = ( 'static/frey.css' );
@status = (
- { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup },
+ { 'ClassBrowser' => Frey::Class::Browser->new( usage_sort => 1, usage_on_top => 0 )->as_markup },
{ 'Bookmarklets' => Frey::Bookmarklet->new->as_markup },
{ 'INC' => Frey::INC->new->as_markup },
);
@@ -440,24 +464,39 @@
sub icon_path {
my ($self,$class,$variant) = @_;
- my $icon = $class;
- $icon =~ s{::}{/}g;
- $icon .= "/$variant" if $variant;
- my $path = 'static/icons/' . $icon . '.png';
- if ( -e $path ) {
- warn "# $class from $self icon_path $path" if $self->debug;
- return $path;
- } else {
- $self->TODO( "add $path icon for $class" );
+
+ sub icon_exists {
+ my $class = shift;
+ $class =~ s{::}{/}g;
+ $class .= "/$variant" if $variant;
+ my $icon_path = 'static/icons/' . $class . '.png';
+ return $icon_path if -e $icon_path;
+ return;
+ }
+
+ my $path = icon_exists( $class );
+ if ( ! $path ) {
+ my $super_class = $class;
+ while ( $super_class =~ s{::[^:]+$}{} && ! $path ) {
+ $path = icon_exists( $super_class ) unless $super_class eq 'Frey'; # don't default on Frey icon
+ }
+ }
+
+ if ( ! $path ) {
+ $self->TODO( "add icon for $class" . ( $variant ? " variant $variant" : '' ) );
return undef;
}
+
+ warn "# $class from $self icon_path $path" if $self->debug;
+ return $path;
}
sub add_icon {
my ($self,$variant) = @_;
- my $class = ref($self);
- $class = $self->class if $self->can('class');
+ my $class = $self->class if $self->can('class');
+ #$class ||= $self->title;
+ $class ||= ref($self);
my $icon_path = $self->icon_path( $class, $variant ) || return;
$icon_html .= qq||;
@@ -501,12 +540,20 @@
$Frey::Bootstrap::log_path || die "no log_path?";
}
-our $last_log_pos = 0;
-our $last_log_line = 0;
-
our $pwd = `pwd`;
chomp $pwd;
+sub strip_full_path {
+ my ($self, $msg) = @_;
+ # Mojo seems to expand warn messages to full path which is annoying
+ $msg =~ s{/[^/]+/\.\./}{/}gs;
+ $msg =~ s{$pwd/*}{}gs;
+ return $msg;
+}
+
+our $last_log_pos = 0;
+our $last_log_line = 0;
+
sub warnings_html {
my ($self,$level) = shift;
$level ||= $self->debug,
@@ -561,11 +608,7 @@
if ( m{^(#*)} ) {
my $level = $1;
- my $msg = $_;
-
- # Mojo seems to expand warn messages to full path which is annoying
- $msg =~ s{/[^/]+/\.\./}{/}gs;
- $msg =~ s{$pwd/*}{}gs;
+ my $msg = $self->strip_full_path( $_ );
my $spacer = ' ';
my $real_msg = expand( $msg );
@@ -606,7 +649,7 @@
return
# need to wrap editor link into span so we can have links in warnings
qq||
;
}
@@ -639,4 +682,39 @@
return @backtrace;
}
+=head2 checkbox
+
+Generate checkbox html markup from some attribute
+
+ my $html = $self->checkbox('attribute_name', $value);
+
+=cut
+
+sub checkbox {
+ my ($self,$name,$value) = @_;
+ my $checked = '';
+ my $all_checkboxes = eval { $self->$name };
+ warn "ERROR tried to get checkbox value for '$name' which is unknown: $@" if $@;
+ $all_checkboxes = [ $all_checkboxes ] unless ref($all_checkboxes) eq 'ARRAY'; # sigh, too chatty
+ $checked = ' checked' if grep { defined $_ && $_ eq $value } @$all_checkboxes;
+ warn "# checkbox $name $value $checked\t", $self->dump( $self->$name );
+ qq||;
+}
+
+=head2 strip
+
+Strip whitespace around content
+
+ my $stripped = strip(' no more whitespace around this ');
+
+=cut
+
+sub strip {
+ my $t = shift;
+ $t =~ s{^\s+}{}gs;
+ $t =~ s{>\s+<}{><}gs;
+ $t =~ s{\s+$}{}gs;
+ return $t;
+}
+
1;