--- trunk/lib/Frey/Web.pm 2008/12/02 17:34:23 681 +++ trunk/lib/Frey/Web.pm 2008/12/02 17:36:51 682 @@ -86,7 +86,7 @@ $dump =~ s{(\n[^\n]{$width})([^\n]+?)([^\n]{5})}{\n$1...$3}gs; $dump = $self->html_escape( $dump ); $dump =~ s{\Q...\E}{…}gs; -# $dump =~ $self->editor_links( $dump ); # FIXME include this +# $dump =~ $self->html_links( $dump ); # FIXME include this return "$dump"; } @@ -304,17 +304,19 @@ qq|>$class|; } -=head2 editor_links +=head2 html_links Create HTML links to editor for perl error message - my $html = $self->editor_links( $error ) + my $html = $self->html_links( $error ) =cut -sub editor_links { +sub html_links { my ( $self, $error ) = @_; + $error = $self->strip_full_path( $error ); + # $error =~ s[(bless\({\s+.+?\s+},\s+)("[^"]+")(\) at)][$1$2$3]gs; # FIXME insert bless hiding back # perl's backtrace @@ -333,8 +335,11 @@ {$1$2$3}gsm; # link paths to editor - $error =~ s{(lib/[\w/]+\.pm)(\s+(\d+)\s+bytes)} - {$1}gsm; + $error =~ s{((?:lib|t)/[\S]+)\s+(\d+\s+bytes)} + {$1}gsm; + + $error =~ s{(class ")([\w:]+)(")} + {$1$2$3}gsm; return $error; } @@ -362,7 +367,7 @@ warn "ERROR: $error\n"; return qq|
|
-		. $self->editor_links( $error ) .
+		. $self->html_links( $error ) .
 		qq|
| ; } @@ -501,12 +506,20 @@ $Frey::Bootstrap::log_path || die "no log_path?"; } -our $last_log_pos = 0; -our $last_log_line = 0; - our $pwd = `pwd`; chomp $pwd; +sub strip_full_path { + my ($self, $msg) = @_; + # Mojo seems to expand warn messages to full path which is annoying + $msg =~ s{/[^/]+/\.\./}{/}gs; + $msg =~ s{$pwd/*}{}gs; + return $msg; +} + +our $last_log_pos = 0; +our $last_log_line = 0; + sub warnings_html { my ($self,$level) = shift; $level ||= $self->debug, @@ -561,11 +574,7 @@ if ( m{^(#*)} ) { my $level = $1; - my $msg = $_; - - # Mojo seems to expand warn messages to full path which is annoying - $msg =~ s{/[^/]+/\.\./}{/}gs; - $msg =~ s{$pwd/*}{}gs; + my $msg = $self->strip_full_path( $_ ); my $spacer = ' '; my $real_msg = expand( $msg ); @@ -606,7 +615,7 @@ return # need to wrap editor link into span so we can have links in warnings qq|warn| - . $self->editor_links( $warnings ) + . $self->html_links( $warnings ) . qq|| ; }