--- trunk/lib/Frey/Web.pm 2008/11/27 21:31:02 564 +++ trunk/lib/Frey/Web.pm 2008/12/02 01:49:49 674 @@ -7,7 +7,7 @@ #use Continuity::Widget::DomNode; use Data::Dump qw/dump/; -use Carp qw/confess cluck/; +use Carp qw/confess cluck carp/; use File::Slurp; use Frey::Bookmarklet; @@ -16,16 +16,19 @@ use Frey::SVK; -has 'head' => ( - is => 'rw', - isa => 'ArrayRef[Str]', - default => sub { [ 'static/frey.css' ] }, -); +use Text::Tabs; # expand, unexpand + +our @head; +sub head { @head } has 'request_url' => ( is => 'rw', isa => 'Uri', coerce => 1, - default => '/', + required => 1, + default => sub { + carp "undefined request_url"; + '/'; + }, ); has 'title' => ( @@ -64,7 +67,7 @@ is => 'rw', isa => 'Int', # required => 1, # FIXME we can't have required fields with defaults because Frey::Action isn't smart enough and asks for them - default => 128, + default => 250, ); my %escape = ('<'=>'<', '>'=>'>', '&'=>'&', '"'=>'"'); @@ -83,13 +86,14 @@ $dump =~ s{(\n[^\n]{$width})([^\n]+?)([^\n]{5})}{\n$1...$3}gs; $dump = $self->html_escape( $dump ); $dump =~ s{\Q...\E}{…}gs; +# $dump =~ $self->editor_links( $dump ); # FIXME include this return "$dump"; } sub popup { my $self = shift; $self->popup_dropdown('popup', @_); } sub dropdown { my $self = shift; $self->popup_dropdown('dropdown', @_); } -our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1)>}s; # relaxed html check for one semi-valid tag +our $re_html = qr{<(?:!--.+?--|(\w+).+?/\1|[^>]+/)>}s; # relaxed html check for one semi-valid tag sub popup_dropdown { my ( $self, $type, $name, $content, $full ) = @_; @@ -98,10 +102,14 @@ $content = qq|$content| unless $content =~ m{^\s*<(span|a|code).+?/\1>\s*}; - warn "## $type [$name] = ", length( $content ), " bytes" if $self->debug; + $content =~ s{([^<]+)}{$1} && $self->TODO("code wrapped in span"); + + warn "## $type [$name] = ", length( $content ), " bytes"; # if $self->debug; # FIXME if ( $name =~ m{::} && $name !~ $re_html ) { return qq|$name $content\n|; + } elsif ( $name =~ s{^\s*($name $content\n|; } @@ -115,15 +123,15 @@ sub _head_html { my $self = shift; my $out = ''; - foreach my $path ( @{ $self->head } ) { + foreach my $path ( @head ) { $path =~ s!^/!!; if ( $path =~ m/\.js$/ ) { $out .= $self->_inline_path( $path ) ? - qq|| : + qq|| : qq||; } elsif ( $path =~ m/\.css$/ ) { $out .= $self->_inline_path( $path ) ? - qq|| : + qq|| : qq||; } elsif ( $path =~ m{<.+>}s ) { $out .= $path; @@ -151,10 +159,10 @@ $path =~ s!^/!!; if ( $path =~ $re_html ) { - push @{ $self->head }, $path; + push @head, $path; } elsif ( -e $path ) { if ( $path =~ m/\.(?:js|css)$/ ) { - push @{ $self->head }, $path; + push @head, $path; } else { confess "can't add_head( $path ) it's not js or css"; } @@ -165,6 +173,17 @@ } +sub add_css { + my ($self,$css) = @_; + my ( $package, $path, $line ) = caller; + $self->add_head( qq| + + | ); +} + our $reload_counter = 0; @@ -193,10 +212,6 @@ my $status_line = ''; - unshift @status, { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup }; -# unshift @status, { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }; - unshift @status, { 'INC' => Frey::INC->new->as_markup }; - foreach my $part ( @status ) { foreach my $name ( keys %$part ) { $status_line .= $self->popup( $name, $part->{$name} ); @@ -207,7 +222,14 @@ $url =~ s{\?reload=\d+}{}; my $body = $a->{body}; - $body ||= $self->as_markup if $self->can('as_markup'); + if ( ! $body ) { + my $run = $a->{run} || 'as_markup'; + warn "# no body, invoke $self->$run on ", ref($self); + eval { + $body = $self->$run; + }; + $body = $self->error( $@, '' ) if $@; + } if ( $self->content_type !~ m{html} ) { warn "# return only $self body ", $self->content_type; return $body @@ -226,12 +248,13 @@ qq| reload - $exit + $exit |; - my $info = Frey::SVK->info; - my $revision = Frey::SVK->info->{Revision} || ''; + my $svk = Frey::SVK->new; + my $info = $svk->info; + my $revision = $svk->info->{Revision} || ''; $revision = $1 if $info->{'Mirrored From'} =~ m{Rev\.\s+(\d+)}; $self->add_icon unless $icon_html; @@ -292,49 +315,118 @@ sub editor_links { my ( $self, $error ) = @_; +# $error =~ s[(bless\({\s+.+?\s+},\s+)("[^"]+")(\) at)][$1$2$3]gs; # FIXME insert bless hiding back + + # perl's backtrace $error =~ s{at\s+(\S+)\s+line\s+(\d+)} {at $1 line $2}gsm; - $error =~ s{(via package ")([\w:]+)(")} - {$1$2$3}gsm; + $error =~ s{(via (?:package)\s+"?)([\w:]+)("?)} + {$1$2$3}gsm; + + # method error messages +# $error =~ s{(method ")(\w+)"} +# {$1$2"}gsm; # FIXME replace with link to Frey::Introspect data + + # anything that looks like "Class::Name" + $error =~ s{"(\w+(?:::\w+)+)"} + {"$1"}gsm; return $error; } +=head2 error + +This method will return error to browser and backtrace unless +error message ends with LF C<\n> just like L + +=cut + sub error { my $self = shift; my $error = join(" ", @_); - my @backtrace = $self->backtrace; - $error .= "\n\t" . join( "\n\t", @backtrace ) if @backtrace; + my $fatal = ''; + + if ( $error !~ m{\n$} ) { + if ( my @backtrace = $self->backtrace ) { + $error .= "\n\t" . join( "\n\t", @backtrace ); + $fatal = qq| class="fatal"|; + } + } warn "ERROR: $error\n"; return - qq|
|
+		qq|
|
 		. $self->editor_links( $error ) .
 		qq|
| ; } +=head1 Status line + +=head2 add_status + + $self->add_status( { name => { some => 'data' } } ); + + $self->add_status( "append to last status popup" ); + +=cut + sub add_status { my ( $self, $data ) = @_; - push @status, $data; + push @status, { 'X' => [ $self->backtrace ] }; + if ( ref($data) ) { + push @status, $data; + } else { + if ( defined $status[ $#status ] ) { + $status[ $#status ]->{ '+' } = $data; + } else { + push @status, { '+' => $data }; + } + } } +=head2 clean_status + +Called at beginning of each request + + $self->clean_status; + +=cut + sub clean_status { - @status = (); + my ($self) = shift; + @head = ( 'static/frey.css' ); + @status = ( + { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup }, + { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }, + { 'INC' => Frey::INC->new->as_markup }, + ); $icon_html = ''; } +=head2 status_parts + +Dump all status line parts + + $self->status_parts + +=cut + sub status_parts { warn "## status parts ", dump( map { keys %$_ } @status ); } +=for debug + sub DEMOLISH { my ( $self ) = @_; warn "## $self DEMOLISH status ", $#status + 1, " elements ", dump( map { keys %$_ } @status ) if @status; } +=cut + =head2 add_icon Frey::Foo->add_icon; # /static/icons/Frey/Foo.png @@ -349,7 +441,7 @@ $icon .= "/$variant" if $variant; my $path = 'static/icons/' . $icon . '.png'; if ( -e $path ) { - warn "# $class from $self icon_path $path"; + warn "# $class from $self icon_path $path" if $self->debug; return $path; } else { $self->TODO( "add $path icon for $class" ); @@ -394,29 +486,57 @@ '"' => '"', }; +=for later + my $multiline_re = '[\\' . join('\\', keys %$multiline_markers ) . ']'; warn "## multiline markers ", dump( $multiline_markers ), " -> $multiline_re"; +=cut + sub log_path { - $Frey::Bootstrap::log_path || warn "no log_path?"; + $Frey::Bootstrap::log_path || die "no log_path?"; } +our $last_log_pos = 0; +our $last_log_line = 0; + +our $pwd = `pwd`; +chomp $pwd; + sub warnings_html { my ($self,$level) = shift; $level ||= $self->debug, my $path = $self->log_path; - my $warnings; - my $line = 0; + my $max = 30; + my $pos = 0; + my @warnings = ( '' x $max ); # XXX circualar buffer for 50 lines + my $line = $last_log_line; my $multiline_end; - open(my $log, '<', $path) || die "can't open $path: $!"; + # XXX do we really want to do this every time? + my $css = qq|/* short css classes for levels */\n|; + my $level_to_class; + foreach ( keys %$warn_colors ) { + my $l = length($_); + my $class = 'l' . $l; + $css .= qq|.$class { color: $warn_colors->{$_} }\n|; + $level_to_class->{ $_ } = $class; + } + $self->add_css( $css ); + + open(my $log, '<', $path) || die "can't open $path: $!"; + seek($log, $last_log_pos, 0) || warn "can't seek: $!"; while(<$log>) { chomp; $line++; + next if m{^\s+(Mojo|Class::MOP|Moose)::}; + my $style = ''; +=for filter + if ( $multiline_end ) { if ( m{^\Q$multiline_end\E} || m{^\s.+\Q$multiline_end\E;$} ) { # warn "## $line end of $multiline_end in '$_'\n"; @@ -433,27 +553,57 @@ next; } - $style = $warn_colors->{$1} - ? ' style="color:' . $warn_colors->{$1} . '"' - : ''; +=cut + if ( m{^(#*)} ) { + + my $level = $1; + my $msg = $_; + + # Mojo seems to expand warn messages to full path which is annoying + $msg =~ s{/[^/]+/\.\./}{/}gs; + $msg =~ s{$pwd/*}{}gs; - my $msg = $self->html_escape( $_ ); my $spacer = ' '; - if ( length($msg) > $self->html_dump_width ) { - $msg = substr( $msg, 0, $self->html_dump_width ); + my $real_msg = expand( $msg ); + if ( length($real_msg) > $self->html_dump_width ) { + + $real_msg = substr( $msg, 0, $self->html_dump_width ); + $msg = unexpand( $real_msg ); $spacer = '…' } - $msg =~ s{^\s}{ }g; - $warnings .= qq|$msg$spacer+$line
|; - # FIXME should be but CSS hates me + + $msg = $self->html_escape( $msg ); + + if ( my $class = $level_to_class->{ $level } ) { + $msg = qq|$msg|; + } + + #$msg .= $spacer . qq|$line\n|; + $msg = qq|$line$msg| + . ( $spacer ? $spacer : '' ) + . "\n"; # XXX
 needs this
+
+			$warnings[ $pos++ % $max ] = $msg;
 		}
 	}
+	$last_log_pos = tell($log);
+	$last_log_line = $line;
+	warn "log has $line lines tell position $last_log_pos";
 	close($log) || die "can't close $path: $!";
 
+	my $size = -s $path;
+
+	my $warnings = join("",
+		map { $warnings[ ( $pos + $_ ) % $max ] || '' } 0 .. ( $max - 1 )
+	);
+
+	my $s = length($warnings);
+
 	return
-		  qq|warn|
+		# need to wrap editor link into span so we can have links in warnings
+		  qq|warn|
 		. $self->editor_links( $warnings )
-		. qq||
+		. qq||
 		;
 }
 
@@ -479,9 +629,9 @@
 		) = caller($_) or last;
 
 		push @backtrace,
-			qq|via $package from $path $path|;
+			qq|via "$package" at $path line $line|;
 	}
-	warn "# backtrace: ", dump( @backtrace ) if @backtrace;
+	#warn "# backtrace: ", dump( @backtrace ) if @backtrace;
 	return @backtrace;
 }