--- trunk/lib/Frey/Web.pm	2008/11/28 23:34:26	611
+++ trunk/lib/Frey/Web.pm	2008/12/02 02:01:23	677
@@ -7,7 +7,7 @@
 
 #use Continuity::Widget::DomNode;
 use Data::Dump qw/dump/;
-use Carp qw/confess cluck/;
+use Carp qw/confess cluck carp/;
 use File::Slurp;
 
 use Frey::Bookmarklet;
@@ -24,7 +24,11 @@
 has 'request_url' => (
 	is => 'rw',
 	isa => 'Uri', coerce => 1,
-	default => '/',
+	required => 1,
+	default => sub {
+		carp "undefined request_url";
+		'/';
+	},
 );
 
 has 'title' => (
@@ -63,7 +67,7 @@
 	is => 'rw',
 	isa => 'Int',
 #	required => 1, # FIXME we can't have required fields with defaults because Frey::Action isn't smart enough and asks for them
-	default => 120,
+	default => 250,
 );
 
 my %escape = ('<'=>'&lt;', '>'=>'&gt;', '&'=>'&amp;', '"'=>'&quot;');
@@ -221,7 +225,10 @@
 	if ( ! $body ) {
 		my $run = $a->{run} || 'as_markup';
 		warn "# no body, invoke $self->$run on ", ref($self);
-		$body = $self->$run;
+		eval {
+			$body = $self->$run;
+		};
+		$body = $self->error( $@, '' ) if $@;
 	}
 	if ( $self->content_type !~ m{html} ) {
 		warn "# return only $self body ", $self->content_type;
@@ -241,7 +248,7 @@
 		qq|
 			<span class="right">
 			<a title="reload $url"  href="/reload$url">reload</a>
-			<a title="$description" href="/exit$url">$exit</a>
+			<a title="$description" href="/exit$url" target="exit">$exit</a>
 			</span>
 		|;
 
@@ -310,25 +317,48 @@
 
 #	$error =~ s[(bless\({\s+.+?\s+},\s+)("[^"]+")(\) at)][<span class="frey-dropdown">$1<code>$2</code>$3</span>]gs; # FIXME insert bless hiding back
 
+	# perl's backtrace
 	$error =~ s{at\s+(\S+)\s+line\s+(\d+)}
-		{at <a target="editor" href="/editor+$1+$2">$1</a> line $2}gsm;
+		{at <a target="editor" href="/editor+$1+$2" title="vi $1 +$2">$1</a> line $2}gsm;
+
+	$error =~ s{(via (?:package)\s+"?)([\w:]+)("?)}
+		{$1<a target="$2" href="/$2" title="introspect $2">$2</a>$3}gsm
+	|| # or anything that looks like "Class::Name"
+	$error =~ s{"(\w+(?:::\w+)+)"}
+		{"<a target="$1" href="/$1" title="introspect $1">$1</a>"}gsm;
+
+	# method error messages
+	# FIXME replace with link to Frey::Introspect data
+	$error =~ s{(method ")(\w+)(" via)}
+		{$1<a target="$2" href="/Frey::Shell::Grep/as_markup?pattern=$2" title="grep $2">$2</a>$3}gsm;
 
-	$error =~ s{(via (?:package) "?)([\w:]+)("?)}
-		{$1<a target="editor" href="/editor+$2+1">$2</a>$3}gsm;
 
 	return $error;
 }
 
+=head2 error
+
+This method will return error to browser and backtrace unless
+error message ends with LF C<\n> just like L<warn>
+
+=cut
+
 sub error {
 	my $self = shift;
 	my $error = join(" ", @_);
 
-	my @backtrace = $self->backtrace;
-	$error .= "\n\t" . join( "\n\t", @backtrace ) if @backtrace;
+	my $fatal = '';
+
+	if ( $error !~ m{\n$} ) {
+		if ( my @backtrace = $self->backtrace ) {
+			$error .= "\n\t" . join( "\n\t", @backtrace );
+			$fatal = qq| class="fatal"|;
+		}
+	}
 
 	warn "ERROR: $error\n";
 	return
-		qq|<pre class="frey-error">|
+		qq|<pre class="frey-error$fatal">|
 		. $self->editor_links( $error ) .
 		qq|</pre>|
 		;
@@ -372,7 +402,7 @@
 	@status = (
 		{ 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup },
 		{ 'Bookmarklets' => Frey::Bookmarklet->new->as_markup },
-		{ 'INC' => Frey::INC->new->as_markup },
+		{ 'INC' => Frey::INC->new->as_markup }, 
 	);
 	$icon_html = '';
 }
@@ -457,13 +487,23 @@
 	'"' => '"',
 };
 
+=for later
+
 my $multiline_re = '[\\' . join('\\', keys %$multiline_markers ) . ']';
 warn "## multiline markers ", dump( $multiline_markers ), " -> $multiline_re";
 
+=cut
+
 sub log_path {
-	$Frey::Bootstrap::log_path || warn "no log_path?";
+	$Frey::Bootstrap::log_path || die "no log_path?";
 }
 
+our $last_log_pos  = 0;
+our $last_log_line = 0;
+
+our $pwd = `pwd`;
+chomp $pwd;
+
 sub warnings_html {
 	my ($self,$level) = shift;
 	$level ||= $self->debug,
@@ -472,7 +512,7 @@
 	my $max = 30;
 	my $pos = 0;
 	my @warnings = ( '' x $max ); # XXX circualar buffer for 50 lines
-	my $line = 0;
+	my $line = $last_log_line;
 	my $multiline_end;
 
 	# XXX do we really want to do this every time?
@@ -486,11 +526,14 @@
 	}
 	$self->add_css( $css );
 
-	open(my $log, '<', $path) || die "can't open $path: $!";
+	open(my $log, '<', $path)    || die "can't open $path: $!";
+	seek($log, $last_log_pos, 0) || warn "can't seek: $!";
 	while(<$log>) {
 		chomp;
 		$line++;
 
+		next if m{^\s+(Mojo|Class::MOP|Moose)::};
+
 		my $style = '';
 
 =for filter
@@ -517,6 +560,10 @@
 			my $level = $1;
 			my $msg = $_;
 
+			# Mojo seems to expand warn messages to full path which is annoying
+			$msg =~ s{/[^/]+/\.\./}{/}gs;
+			$msg =~ s{$pwd/*}{}gs;
+
 			my $spacer = ' ';
 			my $real_msg = expand( $msg );
 			if ( length($real_msg) > $self->html_dump_width ) {
@@ -532,19 +579,23 @@
 				$msg = qq|<span class="$class">$msg</span>|;
 			}
 
-			$msg .= $spacer .
-				qq|<a target="editor" href="/editor+$path+$line" style="float: right;">+$line</a>\n|;
+			#$msg .= $spacer . qq|<a target="editor" href="/editor+$path+$line" style="float: right;">$line</a>\n|;
+			$msg = qq|<a target="editor" href="/editor+$path+$line" style="float: right;">$line</a>$msg|
+				. ( $spacer ? $spacer : '' )
+				. "\n"; # XXX <pre> needs this
 
 			$warnings[ $pos++ % $max ] = $msg;
 		}
 	}
-	warn "log has $line lines tell position ",tell($log);
+	$last_log_pos = tell($log);
+	$last_log_line = $line;
+	warn "log has $line lines tell position $last_log_pos";
 	close($log) || die "can't close $path: $!";
 
 	my $size = -s $path;
 
 	my $warnings = join("",
-		map { $warnings[ ( $pos + $_ ) % $max ] || '' } 1 .. $max 
+		map { $warnings[ ( $pos + $_ ) % $max ] || '' } 0 .. ( $max - 1 )
 	);
 
 	my $s = length($warnings);
@@ -553,7 +604,7 @@
 		# need to wrap editor link into span so we can have links in warnings
 		  qq|<span class="frey-popup"><a target="editor" href="/editor+$path+$line" title="$path \| $size -> $s bytes \| $line -> $pos lines \| level $level">warn</a><code>|
 		. $self->editor_links( $warnings )
-		. qq|</code></span></a>|
+		. qq|</code></span>|
 		;
 }
 
@@ -579,7 +630,7 @@
 		) = caller($_) or last;
 
 		push @backtrace,
-			qq|via $package at $path line $line|;
+			qq|via "$package" at $path line $line|;
 	}
 	#warn "# backtrace: ", dump( @backtrace ) if @backtrace;
 	return @backtrace;