--- trunk/lib/Frey/Web.pm 2008/11/28 00:42:35 578 +++ trunk/lib/Frey/Web.pm 2008/11/28 15:07:03 588 @@ -17,6 +17,7 @@ use Frey::SVK; our @head; +sub head { @head } has 'request_url' => ( is => 'rw', @@ -79,6 +80,7 @@ $dump =~ s{(\n[^\n]{$width})([^\n]+?)([^\n]{5})}{\n$1...$3}gs; $dump = $self->html_escape( $dump ); $dump =~ s{\Q...\E}{…}gs; +# $dump =~ $self->editor_links( $dump ); # FIXME include this return "$dump"; } @@ -94,10 +96,14 @@ $content = qq|$content| unless $content =~ m{^\s*<(span|a|code).+?/\1>\s*}; + $content =~ s{([^<]+)}{$1} && $self->TODO("code wrapped in span"); + warn "## $type [$name] = ", length( $content ), " bytes" if $self->debug; if ( $name =~ m{::} && $name !~ $re_html ) { return qq|$name $content\n|; + } elsif ( $name =~ s{^\s*($name $content\n|; } @@ -166,7 +172,7 @@ my ( $package, $path, $line ) = caller; $self->add_head( qq| | ); @@ -200,10 +206,6 @@ my $status_line = ''; - unshift @status, { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup }; -# unshift @status, { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }; - unshift @status, { 'INC' => Frey::INC->new->as_markup }; - foreach my $part ( @status ) { foreach my $name ( keys %$part ) { $status_line .= $self->popup( $name, $part->{$name} ); @@ -303,7 +305,7 @@ $error =~ s{at\s+(\S+)\s+line\s+(\d+)} {at $1 line $2}gsm; - $error =~ s{(via package ")([\w:]+)(")} + $error =~ s{(via (?:package) "?)([\w:]+)("?)} {$1$2$3}gsm; return $error; @@ -328,7 +330,7 @@ =head2 add_status - $self->add_status( name => { some => 'data' } ); + $self->add_status( { name => { some => 'data' } } ); $self->add_status( "append to last status popup" ); @@ -336,10 +338,15 @@ sub add_status { my ( $self, $data ) = @_; + push @status, { 'X' => [ $self->backtrace ] }; if ( ref($data) ) { push @status, $data; } else { - $status[ $#status ]->{added} = $data; + if ( defined $status[ $#status ] ) { + $status[ $#status ]->{ '+' } = $data; + } else { + push @status, { '+' => $data }; + } } } @@ -354,7 +361,11 @@ sub clean_status { my ($self) = shift; @head = ( 'static/frey.css' ); - @status = (); + @status = ( + { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup }, + { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }, + { 'INC' => Frey::INC->new->as_markup }, + ); $icon_html = ''; } @@ -450,7 +461,9 @@ $level ||= $self->debug, my $path = $self->log_path; - my $warnings; + my $max = 50; + my $pos = 0; + my @warnings = ( '' x $max ); # XXX circualar buffer for 50 lines my $line = 0; my $multiline_end; @@ -461,6 +474,8 @@ my $style = ''; +=for filter + if ( $multiline_end ) { if ( m{^\Q$multiline_end\E} || m{^\s.+\Q$multiline_end\E;$} ) { # warn "## $line end of $multiline_end in '$_'\n"; @@ -477,6 +492,9 @@ next; } +=cut + if ( m{^(#*)\s+} ) { # FIXME + $style = $warn_colors->{$1} ? ' style="color:' . $warn_colors->{$1} . '"' : ''; @@ -487,17 +505,30 @@ $msg = substr( $msg, 0, $self->html_dump_width ); $spacer = '…' } - $msg =~ s{^\s}{ }g; - $warnings .= qq|$msg$spacer+$line
|; + $warnings[ $pos++ % $max ] + = $msg +# = ( $style ? qq|$msg| : $msg ) + . $spacer + . qq|+$line
|; # FIXME should be but CSS hates me } } close($log) || die "can't close $path: $!"; + my $size = -s $path; + + my $warnings = join('', + map { $warnings[ ( $pos + $_ ) % $max ] || '' } 0 .. $max + ); + + my $s = length($warnings); + return - qq|warn| - . $self->editor_links( $warnings ) - . qq|| + # need to wrap into span so we can have links in warnings + qq|warn| + . $warnings +# . $self->editor_links( $warnings ) + . qq|| ; } @@ -523,7 +554,7 @@ ) = caller($_) or last; push @backtrace, - qq|via package $package at $path line $line|; + qq|via $package at $path line $line|; } warn "# backtrace: ", dump( @backtrace ) if @backtrace; return @backtrace;