--- trunk/lib/Frey/Web.pm 2008/11/19 03:00:46 445 +++ trunk/lib/Frey/Web.pm 2008/11/20 15:23:13 482 @@ -1,6 +1,8 @@ package Frey::Web; use Moose::Role; +with 'Frey::Backtrace'; + use Frey::Types; use Continuity::Widget::DomNode; @@ -22,8 +24,8 @@ isa => 'ArrayRef[HashRef[Str]]', lazy => 1, default => sub { [ - { 'Bookmarklets' => Frey::Bookmarklet->new->markup }, - { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->markup }, + { 'ClassBrowser' => Frey::ClassBrowser->new( usage_on_top => 0 )->as_markup }, + { 'Bookmarklets' => Frey::Bookmarklet->new->as_markup }, ] }, ); @@ -43,6 +45,20 @@ }, ); +has 'content_type' => ( + is => 'rw', + isa => 'Str', + default => 'text/html', + documentation => 'Content-type header', +); + +has 'dump_max_bytes' => ( + is => 'rw', + isa => 'Int', + default => 4096, + documentation => 'Maximum dump size sent to browser before truncation', +); + =head2 inline_smaller_than Inline JavaScript and CSS smaller than this size into page reducing @@ -79,7 +95,7 @@ $out .= $self->_inline_path( $path ) ? qq|| : qq||; - } elsif ( $path =~ m{<.+>} ) { + } elsif ( $path =~ m{<.+>}s ) { $out .= $path; } else { confess "don't know how to render $path"; @@ -104,7 +120,7 @@ return if ! defined $path || $path eq ''; $path =~ s!^/!!; - if ( $path =~ m{<.*>} ) { + if ( $path =~ m{<.*>}s ) { push @{ $self->head }, $path; } elsif ( -e $path ) { if ( $path =~ m/\.(?:js|css)$/ ) { @@ -150,7 +166,7 @@ if ( ref($content) ) { $content = '' . dump($content) . ''; my $l = length($content); - $content = qq|$l bytes| if $l > 1024; + $content = qq|$l bytes| if $l > $self->dump_max_bytes; } else { $content = qq|$content|; } @@ -162,19 +178,62 @@ my $url = $self->request_url; $url =~ s{\?reload=\d+}{}; + my $body = $a->{body}; + $body ||= $self->as_markup if $self->can('as_markup'); + if ( $self->content_type !~ m{html} ) { + warn "# return only $self body ", $self->content_type; + return $body + } elsif ( ! defined $body ) { + warn "# no body"; + $body = ''; + } + + my $warn_colors = { + '#' => '#444', + '##' => '#888', + }; + + $status_line + .= qq|warn| + . $self->editor_links( + join("", map { + warn "# $_"; + my $style = ''; + $style = $warn_colors->{$1} + ? ' style="color:' . $warn_colors->{$1} . '"' + : '' + if m{^(#+)}; + qq|$_
|; # XXX should be but CSS hates me + } $self->warnings ) + ) + . qq|
| + if $self->warnings; + + my ($exit,$description) = ('exit','stop server'); + ($exit,$description) = ('restart','restart server') + if $ENV{FREY_RESTART}; # tune labels on exit link + + my $right = + qq| + + $url + $exit + + |; + my $html = join("\n", qq||, $self->_head_html, '' . ( $self->title || $a->{title} || ref($self) ) . '', '', ( $a->{head} || '' ), - '', - ( $a->{body} || $self->markup || '' ), qq| + + $body
Frey $Frey::VERSION - $url $status_line + $right
|, @@ -185,15 +244,56 @@ return $html; } +=head2 editor + +Create HTML editor link with optional line and title + + my $html = $self->editor( $class, $line, $title ); + +=cut + +sub editor { + my ( $self, $class, $line, $title ) = @_; + confess "need class" unless $class; + $line ||= 1; + qq|$class|; +} + +=head2 editor_links + +Create HTML links to editor for perl error message + + my $html = $self->editor_links( $error ) + +=cut + +sub editor_links { + my ( $self, $error ) = @_; + + $error =~ s{at\s+(\S+)\s+line\s+(\d+)} + {at $1 line $2}gsm; + + $error =~ s{(via package ")([\w:]+)(")} + {$1$2$3}gsm; + + return $error; +} + sub error { my $self = shift; my $error = join(" ", @_); - my ($package, $filename, $line) = caller; - $error .= " at $filename line $line" if $error !~ m{ at }; - warn "WARN: $error\n"; - $error =~ s{at\s+(\S+)\s+line\s+(\d+)}{at $1 line $2}gsm; - $error =~ s{(via package ")([\w:]+)(")}{$1$2$3}gsm; - return qq|
$error
|; + + my @backtrace = $self->backtrace; + $error .= "\n\t" . join( "\n\t", @backtrace ) if @backtrace; + + warn "ERROR: $error\n"; + return + qq|
|
+		. $self->editor_links( $error ) .
+		qq|
| + ; } 1;