--- trunk/bin/BackupPC_updatedb 2005/06/23 10:14:10 7 +++ trunk/bin/BackupPC_updatedb 2005/06/23 12:22:21 8 @@ -1,4 +1,4 @@ -#!/usr/local/bin/perl -w +#!/usr/local/bin/perl $| = 1; use strict; @@ -127,13 +127,13 @@ #################################INSERT VALUES############################# # get hosts -$hosts = $bpc->HostInfoRead("localhost"); -my $host_key; +$hosts = $bpc->HostInfoRead(); +print Dumper($hosts); my $hostID; my $shareID; -foreach $host_key (keys %{$hosts}) +foreach my $host_key (keys %{$hosts}) { - my $hostname = $hosts->{$host_key}->{'host'}; + my $hostname = $hosts->{$host_key}->{'host'} || die "can't find host for $host_key"; my $backups; my $sql; @@ -141,8 +141,7 @@ my $st = $dbh->prepare($sql); $st->bind_param(1,$hosts->{$host_key}->{'host'}); $st->execute(); - my $tmp = $st->fetchrow_hashref(); - if ($tmp->{'ID'} ne "") + if (my $tmp = $st->fetchrow_hashref()) { $hostID = $tmp->{'ID'}; }