--- lib/PXElator/dhcpd.pm	2009/08/06 15:15:53	156
+++ lib/PXElator/dhcpd.pm	2009/08/06 21:31:10	168
@@ -18,7 +18,6 @@
 use IO::Socket::INET;
 use File::Slurp;
 use Data::Dump qw/dump/;
-use Net::Ping;
 
 use lib '..';
 use Net::DHCP::Packet;
@@ -35,7 +34,7 @@
 
 warn "server ip $server::ip range: $server::ip_from - $server::ip_to\n";
 
-my $addr = $server::ip_from;
+use client;
 
 sub client_ip {
 	my ( $mac ) = @_;
@@ -49,16 +48,7 @@
 		return $ip;
 	}
 
-	my $p = Net::Ping->new;
-
-	my $prefix = $server::ip;
-	$prefix =~ s{\.\d+$}{.};
-	my $ip = $prefix . $addr;
-
-	while ( -e "$conf/ip/$ip" || $p->ping( $ip ) ) {
-		$ip = $prefix . $addr++;
-		die "all addresses allocated!" if $addr == $server::ip_to;
-	}
+	my $ip = client::next_ip;
 
 	write_file "$conf/mac/$mac", $ip;
 
@@ -79,6 +69,7 @@
 use log;
 use config;
 use pxelinux;
+use client;
 
 our $file;
 our $transaction = 0; # FIXME predictible transaction numbers
@@ -129,15 +120,41 @@
 		Giaddr	=> $dhcp->giaddr(),
 		Chaddr	=> $dhcp->chaddr(),
 		File	=> $file,
+		DHO_DHCP_SERVER_IDENTIFIER()	=> $server::ip,	# busybox/udhcpc needs it but doesn't request
+	};
+
+	my $options = {
+		DHO_SUBNET_MASK()	=> $server::netmask,
+		DHO_ROUTERS()		=> $server::ip,
+		DHO_DOMAIN_NAME()	=> $server::domain_name,
+		DHO_NAME_SERVERS()	=> $server::ip,
+		DHO_DOMAIN_NAME_SERVERS() => $server::ip,
+		DHO_HOST_NAME()		=> client::conf( $ip, 'hostname' ),
+		DHO_BROADCAST_ADDRESS() => $server::bcast,
+#		DHO_NTP_SERVERS() => '',
 	};
 
+	my @requested = split(/\s/, $dhcp->getOptionValue(DHO_DHCP_PARAMETER_REQUEST_LIST));
+	warn "options ",dump( $options ), ' requested: ',dump( @requested ) if $debug;
+
+	my @missing;
+	foreach ( @requested ) {
+		if ( defined $options->{$_} ) {
+			$packet->{$_} = $options->{$_};
+		} else {
+			push @missing, $_;
+		}
+	}
+
+	warn "W: options requested but missing: ",dump( @missing ),$/;
+
 	foreach my $opt ( 'magic', 'config_file', 'path_prefix', 'reboot_time' ) {
 		my $DH0 = eval 'DHO_PXELINUX_' . uc $opt;
 		warn "DH0: $@" if $@;
 		my $v = eval "\$pxelinux::$opt";
 		warn "v: $@" if $@;
 		next unless defined $v;
-		warn "pxelinux dhcp option $opt = $DH0 = $v";
+		warn "pxelinux dhcp option $opt = $DH0 = $v\n" if $debug;
 		$packet->{ $DH0 } = $v;
 	}
 
@@ -153,11 +170,6 @@
 		if ( $ip eq $requested_ip ) {
 			$packet->{DHO_DHCP_MESSAGE_TYPE()}      = DHCPACK();
 			$packet->{DHO_DHCP_LEASE_TIME()}        = 5 * 60; # 5 min
-#			$packet->{DHO_DHCP_SERVER_IDENTIFIER()} = $server::ip;		# FIXME
-			$packet->{DHO_SUBNET_MASK()}            = '255.255.255.0';
-			$packet->{DHO_ROUTERS()}                = $server::ip;
-			$packet->{DHO_DOMAIN_NAME()}            = 'pxelator.lan';
-			$packet->{DHO_NAME_SERVERS()}           = $server::ip;
 #			$packet->{DHO_ROOT_PATH()}              = '/exports/foobar';
 		} else {
 			$packet->{DHO_DHCP_MESSAGE_TYPE()} = DHCPNAK();
@@ -171,8 +183,6 @@
 
 	warn ">> $mac == $ip server: $server::ip", $file ? " file: $file\n" : "\n" if $debug;
 
-warn "## created packet ", dump( $packet );
-
 	$packet = new Net::DHCP::Packet( %$packet );
 	warn "send ",$packet->toString() if $debug;