--- lib/Redis.pm	2009/03/22 13:37:49	26
+++ lib/Redis.pm	2009/03/22 18:07:46	37
@@ -9,7 +9,7 @@
 
 =head1 NAME
 
-Redis - The great new Redis!
+Redis - perl binding for Redis database
 
 =cut
 
@@ -20,19 +20,21 @@
 
 Pure perl bindings for L<http://code.google.com/p/redis/>
 
+This version support git version of Redis available at
+L<git://github.com/antirez/redis>
+
     use Redis;
 
     my $r = Redis->new();
 
-
-
-
 =head1 FUNCTIONS
 
 =head2 new
 
 =cut
 
+our $debug = $ENV{REDIS} || 0;
+
 our $sock;
 my $server = '127.0.0.1:6379';
 
@@ -53,18 +55,20 @@
 
 sub _sock_result {
 	my $result = <$sock>;
-	warn "# result: ",dump( $result );
+	warn "## result: ",dump( $result ) if $debug;
 	$result =~ s{\r\n$}{} || warn "can't find cr/lf";
 	return $result;
 }
 
 sub _sock_read_bulk {
 	my $len = <$sock>;
-	warn "## bulk len: ",dump($len);
+	warn "## bulk len: ",dump($len) if $debug;
 	return undef if $len eq "nil\r\n";
 	my $v;
-	read($sock, $v, $len) || die $!;
-	warn "## bulk v: ",dump($v);
+	if ( $len > 0 ) {
+		read($sock, $v, $len) || die $!;
+		warn "## bulk v: ",dump($v) if $debug;
+	}
 	my $crlf;
 	read($sock, $crlf, 2); # skip cr/lf
 	return $v;
@@ -72,35 +76,54 @@
 
 sub _sock_result_bulk {
 	my $self = shift;
-	warn "## _sock_result_bulk ",dump( @_ );
+	warn "## _sock_result_bulk ",dump( @_ ) if $debug;
 	print $sock join(' ',@_) . "\r\n";
 	_sock_read_bulk();
 }
 
+sub _sock_result_bulk_list {
+	my $self = shift;
+	warn "## _sock_result_bulk_list ",dump( @_ ) if $debug;
+
+	my $size = $self->_sock_send( @_ );
+	confess $size unless $size > 0;
+	$size--;
+
+	my @list = ( 0 .. $size );
+	foreach ( 0 .. $size ) {
+		$list[ $_ ] = _sock_read_bulk();
+	}
+
+	warn "## list = ", dump( @list ) if $debug;
+	return @list;
+}
+
 sub __sock_ok {
 	my $ok = <$sock>;
+	return undef if $ok eq "nil\r\n";
 	confess dump($ok) unless $ok eq "+OK\r\n";
 }
 
 sub _sock_send {
 	my $self = shift;
-	warn "## _sock_send ",dump( @_ );
+	warn "## _sock_send ",dump( @_ ) if $debug;
 	print $sock join(' ',@_) . "\r\n";
 	_sock_result();
 }
 
 sub _sock_send_ok {
 	my $self = shift;
-	warn "## _sock_send_ok ",dump( @_ );
+	warn "## _sock_send_ok ",dump( @_ ) if $debug;
 	print $sock join(' ',@_) . "\r\n";
 	__sock_ok();
 }
 
 sub __sock_send_bulk_raw {
 	my $self = shift;
-	warn "## _sock_send_bulk ",dump( @_ );
+	warn "## _sock_send_bulk ",dump( @_ ) if $debug;
 	my $value = pop;
-	print $sock join(' ',@_) . ' ' . length($value) . "\r\n$value\r\n";
+	$value = '' unless defined $value; # FIXME errr? nil?
+	print $sock join(' ',@_) . ' ' . length($value) . "\r\n$value\r\n"
 }
 
 sub _sock_send_bulk {
@@ -272,6 +295,8 @@
 
 =head1 Commands operating on lists
 
+See also L<Redis::List> for tie interface.
+
 =head2 rpush
 
   $r->rpush( $key, $value );
@@ -313,18 +338,7 @@
 
 sub lrange {
 	my ( $self, $key, $start, $end ) = @_;
-	my $size = $self->_sock_send('LRANGE', $key, $start, $end);
-
-	confess $size unless $size > 0;
-	$size--;
-
-	my @list = ( 0 .. $size );
-	foreach ( 0 .. $size ) {
-		$list[ $_ ] = _sock_read_bulk();
-	}
-
-	warn "## lrange $key $start $end = [$size] ", dump( @list );
-	return @list;
+	$self->_sock_result_bulk_list('LRANGE', $key, $start, $end);
 }
 
 =head2 ltrim
@@ -362,7 +376,7 @@
 
 =head2 lrem
 
-  $r->lrem( $key, $count, $value );
+  my $modified_count = $r->lrem( $key, $count, $value );
 
 =cut
 
@@ -371,6 +385,96 @@
 	$self->_sock_send_bulk_number( 'LREM', $key, $count, $value );
 }
 
+=head2 lpop
+
+  my $value = $r->lpop( $key );
+
+=cut
+
+sub lpop {
+	my ( $self, $key ) = @_;
+	$self->_sock_result_bulk( 'LPOP', $key );
+}
+
+=head2 rpop
+
+  my $value = $r->rpop( $key );
+
+=cut
+
+sub rpop {
+	my ( $self, $key ) = @_;
+	$self->_sock_result_bulk( 'RPOP', $key );
+}
+
+=head1 Commands operating on sets
+
+=head2 sadd
+
+  $r->sadd( $key, $member );
+
+=cut
+
+sub sadd {
+	my ( $self, $key, $member ) = @_;
+	$self->_sock_send_bulk_number( 'SADD', $key, $member );
+}
+
+=head2 srem
+
+  $r->srem( $key, $member );
+
+=cut
+
+sub srem {
+	my ( $self, $key, $member ) = @_;
+	$self->_sock_send_bulk_number( 'SREM', $key, $member );
+}
+
+=head2 scard
+
+  my $elements = $r->scard( $key );
+
+=cut
+
+sub scard {
+	my ( $self, $key ) = @_;
+	$self->_sock_send( 'SCARD', $key );
+}
+
+=head2 sismember
+
+  $r->sismember( $key, $member );
+
+=cut
+
+sub sismember {
+	my ( $self, $key, $member ) = @_;
+	$self->_sock_send_bulk_number( 'SISMEMBER', $key, $member );
+}
+
+=head2 sinter
+
+  $r->sinter( $key1, $key2, ... );
+
+=cut
+
+sub sinter {
+	my $self = shift;
+	$self->_sock_result_bulk_list( 'SINTER', @_ );
+}
+
+=head2 sinterstore
+
+  my $ok = $r->sinterstore( $dstkey, $key1, $key2, ... );
+
+=cut
+
+sub sinterstore {
+	my $self = shift;
+	$self->_sock_send_ok( 'SINTERSTORE', @_ );
+}
+
 =head1 AUTHOR
 
 Dobrica Pavlinusic, C<< <dpavlin at rot13.org> >>